Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 750983003: DevTools: remove Console.setTracingBasedTimeline call from startup. (Closed)

Created:
6 years ago by pfeldman
Modified:
6 years ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: remove Console.setTracingBasedTimeline call from startup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187154

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -67 lines) Patch
M LayoutTests/inspector/geolocation-emulation-tests-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/inspector-backend-commands-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ConsoleBase.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 4 chunks +1 line, -7 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 5 chunks +1 line, -24 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerConsoleAgent.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/WorkerConsoleAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pfeldman
6 years ago (2014-12-05 16:13:26 UTC) #2
pfeldman
PTAL
6 years ago (2014-12-15 12:51:27 UTC) #3
yurys
lgtm https://codereview.chromium.org/750983003/diff/1/Source/core/inspector/InspectorConsoleAgent.h File Source/core/inspector/InspectorConsoleAgent.h (right): https://codereview.chromium.org/750983003/diff/1/Source/core/inspector/InspectorConsoleAgent.h#newcode58 Source/core/inspector/InspectorConsoleAgent.h:58: InspectorConsoleAgent(InjectedScriptManager*); Should be marked as explicit now.
6 years ago (2014-12-15 13:01:57 UTC) #4
pfeldman
https://codereview.chromium.org/750983003/diff/1/Source/core/inspector/InspectorConsoleAgent.h File Source/core/inspector/InspectorConsoleAgent.h (right): https://codereview.chromium.org/750983003/diff/1/Source/core/inspector/InspectorConsoleAgent.h#newcode58 Source/core/inspector/InspectorConsoleAgent.h:58: InspectorConsoleAgent(InjectedScriptManager*); On 2014/12/15 13:01:57, yurys wrote: > Should be ...
6 years ago (2014-12-15 13:28:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750983003/20001
6 years ago (2014-12-15 14:23:32 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 16:55:10 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187154

Powered by Google App Engine
This is Rietveld 408576698