Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Unified Diff: content/public/browser/content_browser_client.h

Issue 750633003: Implement HasPermission() method in PermissionService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed comments, switched to use BrowserContext, passing PermissionStatus in callback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index c44788bdeab2db9697116dce9e805bb2e4a22994..01885d7db40d9dbed41e571849ec43d0bb778989 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -20,6 +20,7 @@
#include "content/public/browser/permission_type.h"
#include "content/public/common/content_client.h"
#include "content/public/common/media_stream_request.h"
+#include "content/public/common/permission_status.mojom.h"
#include "content/public/common/resource_type.h"
#include "content/public/common/socket_permission_request.h"
#include "content/public/common/window_container_type.h"
@@ -109,6 +110,8 @@ struct Referrer;
struct ShowDesktopNotificationHostMsgParams;
struct WebPreferences;
+typedef base::Callback<void(PermissionStatus)> PermissionStatusCallback;
+
// A mapping from the scheme name to the protocol handler that services its
// content.
typedef std::map<
@@ -452,6 +455,12 @@ class CONTENT_EXPORT ContentBrowserClient {
WebContents* web_contents,
const GURL& frame_url,
const GURL& main_frame_url) {}
+ virtual void HasPermission(
mlamouri (slow - plz ping) 2014/11/24 19:06:01 nit: could you rename this GetPermissionStatus()?
timvolodine 2014/11/27 17:53:42 Done.
+ PermissionType permission,
+ BrowserContext* browser_context,
+ const GURL& requesting_origin,
+ const GURL& embedding_origin,
+ const PermissionStatusCallback& result_callback);
// Returns true if the given page is allowed to open a window of the given
// type. If true is returned, |no_javascript_access| will indicate whether

Powered by Google App Engine
This is Rietveld 408576698