content/public/browser/content_browser_client.cc - Issue 750633003: Implement HasPermission() method in PermissionService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.cc

Issue 750633003: Implement HasPermission() method in PermissionService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed comments, switched to use BrowserContext, passing PermissionStatus in callback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/content_browser_client.h ('K') | « content/public/browser/content_browser_client.h ('k') | content/public/common/BUILD.gn » ('j') | content/public/common/permission_status.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.cc

diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc

index e32344940ef368946620a3856aceb1006f125c10..657e93f05b228ee0ca3ad995049723f186689d18 100644

--- a/content/public/browser/content_browser_client.cc

+++ b/content/public/browser/content_browser_client.cc

@@ -237,6 +237,15 @@ void ContentBrowserClient::RequestPermission(

result_callback.Run(true);

}

+void ContentBrowserClient::HasPermission(

+ PermissionType permission,

+ BrowserContext* browser_context,

+ const GURL& requesting_origin,

+ const GURL& embedding_origin,

+ const PermissionStatusCallback& result_callback) {

+ result_callback.Run(PERMISSION_STATUS_ASK);

mlamouri (slow - plz ping) 2014/11/24 19:06:01 nit: PERMISSION_STATUS_DENIED.

timvolodine 2014/11/27 17:53:42 changed to denied, but, RequestPermission above do

bool ContentBrowserClient::CanCreateWindow(

const GURL& opener_url,

const GURL& opener_top_level_frame_url,