chrome/browser/chrome_content_browser_client.h - Issue 750633003: Implement HasPermission() method in PermissionService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 750633003: Implement HasPermission() method in PermissionService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed comments, switched to use BrowserContext, passing PermissionStatus in callback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_content_browser_client.h

diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h

index 4ea44b3fb3c4cf201d36398217eeb0dcb79629a8..fbde205df8ef0e0ded081e8ca402a2c1a55cfaca 100644

--- a/chrome/browser/chrome_content_browser_client.h

+++ b/chrome/browser/chrome_content_browser_client.h

@@ -197,6 +197,12 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {

const GURL& requesting_frame,

bool user_gesture,

const base::Callback<void(bool)>& result_callback) override;

+ virtual void HasPermission(

mlamouri (slow - plz ping) 2014/11/24 19:06:01 nit: I think GetPermissionStatus() would be a bett

timvolodine 2014/11/27 17:53:42 Done.

+ content::PermissionType permission,

+ content::BrowserContext* browser_context,

+ const GURL& requesting_origin,

+ const GURL& embedding_origin,

+ const content::PermissionStatusCallback& result_callback) override;

void CancelPermissionRequest(content::PermissionType permission,

content::WebContents* web_contents,

int bridge_id,

« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/browser/chrome_content_browser_client.cc » ('J')