Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/chrome_content_browser_client.h

Issue 750633003: Implement HasPermission() method in PermissionService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed comments, switched to use BrowserContext, passing PermissionStatus in callback Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
6 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_ 6 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 int render_process_id, 190 int render_process_id,
191 scoped_ptr<content::DesktopNotificationDelegate> delegate, 191 scoped_ptr<content::DesktopNotificationDelegate> delegate,
192 base::Closure* cancel_callback) override; 192 base::Closure* cancel_callback) override;
193 void RequestPermission( 193 void RequestPermission(
194 content::PermissionType permission, 194 content::PermissionType permission,
195 content::WebContents* web_contents, 195 content::WebContents* web_contents,
196 int bridge_id, 196 int bridge_id,
197 const GURL& requesting_frame, 197 const GURL& requesting_frame,
198 bool user_gesture, 198 bool user_gesture,
199 const base::Callback<void(bool)>& result_callback) override; 199 const base::Callback<void(bool)>& result_callback) override;
200 virtual void HasPermission(
mlamouri (slow - plz ping) 2014/11/24 19:06:01 nit: I think GetPermissionStatus() would be a bett
timvolodine 2014/11/27 17:53:42 Done.
201 content::PermissionType permission,
202 content::BrowserContext* browser_context,
203 const GURL& requesting_origin,
204 const GURL& embedding_origin,
205 const content::PermissionStatusCallback& result_callback) override;
200 void CancelPermissionRequest(content::PermissionType permission, 206 void CancelPermissionRequest(content::PermissionType permission,
201 content::WebContents* web_contents, 207 content::WebContents* web_contents,
202 int bridge_id, 208 int bridge_id,
203 const GURL& requesting_frame) override; 209 const GURL& requesting_frame) override;
204 void RegisterPermissionUsage(content::PermissionType permission, 210 void RegisterPermissionUsage(content::PermissionType permission,
205 content::WebContents* web_contents, 211 content::WebContents* web_contents,
206 const GURL& frame_url, 212 const GURL& frame_url,
207 const GURL& main_frame_url) override; 213 const GURL& main_frame_url) override;
208 bool CanCreateWindow(const GURL& opener_url, 214 bool CanCreateWindow(const GURL& opener_url,
209 const GURL& opener_top_level_frame_url, 215 const GURL& opener_top_level_frame_url,
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 std::vector<ChromeContentBrowserClientParts*> extra_parts_; 337 std::vector<ChromeContentBrowserClientParts*> extra_parts_;
332 338
333 base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_; 339 base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
334 340
335 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient); 341 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient);
336 }; 342 };
337 343
338 } // namespace chrome 344 } // namespace chrome
339 345
340 #endif // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_ 346 #endif // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/browser/chrome_content_browser_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698