Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 750633003: Implement HasPermission() method in PermissionService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.h
diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h
index 4ea44b3fb3c4cf201d36398217eeb0dcb79629a8..91024d7842b8f86ee556b97984fa56cc54444015 100644
--- a/chrome/browser/chrome_content_browser_client.h
+++ b/chrome/browser/chrome_content_browser_client.h
@@ -197,6 +197,11 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
const GURL& requesting_frame,
bool user_gesture,
const base::Callback<void(bool)>& result_callback) override;
+ virtual void HasPermission(
+ content::PermissionType permission,
+ content::WebContents* web_contents,
mlamouri (slow - plz ping) 2014/11/24 16:01:19 We want to pass a BrowserContext here so we don't
timvolodine 2014/11/24 18:54:21 Done.
+ const GURL& requesting_frame,
mlamouri (slow - plz ping) 2014/11/24 16:01:19 s/requesting_frame/requesting_origin/ Also, you m
timvolodine 2014/11/24 18:54:22 Done.
+ const base::Callback<void(bool)>& result_callback) override;
mlamouri (slow - plz ping) 2014/11/24 16:01:19 The callback shouldn't pass a |bool| back. We want
timvolodine 2014/11/24 18:54:21 done. To do that I extracted permission_status enu
void CancelPermissionRequest(content::PermissionType permission,
content::WebContents* web_contents,
int bridge_id,
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | content/browser/permissions/permission_service_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698