Implement HasPermission() method in PermissionService.

chrome/browser/chrome_content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 179 matching lines @@
       int render_process_id,
       scoped_ptr<content::DesktopNotificationDelegate> delegate,
       base::Closure* cancel_callback) override;
   void RequestPermission(
       content::PermissionType permission,
       content::WebContents* web_contents,
       int bridge_id,
       const GURL& requesting_frame,
       bool user_gesture,
       const base::Callback<void(bool)>& result_callback) override;
+  virtual void HasPermission(
+      content::PermissionType permission,
+      content::WebContents* web_contents,

[mlamouri (slow - plz ping), 2014/11/24 16:01:19]

We want to pass a BrowserContext here so we don't depend on WebContents.

[timvolodine, 2014/11/24 18:54:21]

Done.

+      const GURL& requesting_frame,

[mlamouri (slow - plz ping), 2014/11/24 16:01:19]

s/requesting_frame/requesting_origin/

Also, you might want to pass the embedding_origin like in
PermissionContextBase::GetPermissionStatus().

[timvolodine, 2014/11/24 18:54:22]

Done.

+      const base::Callback<void(bool)>& result_callback) override;

[mlamouri (slow - plz ping), 2014/11/24 16:01:19]

The callback shouldn't pass a |bool| back. We want to have more information, at
least ASK/GRANTED/DENIED.

[timvolodine, 2014/11/24 18:54:21]

done.
To do that I extracted permission_status enum into content/public/common to be
able to include in the content/public/browser/content_browser_client.h

   void CancelPermissionRequest(content::PermissionType permission,
                                content::WebContents* web_contents,
                                int bridge_id,
                                const GURL& requesting_frame) override;
   void RegisterPermissionUsage(content::PermissionType permission,
                                content::WebContents* web_contents,
                                const GURL& frame_url,
                                const GURL& main_frame_url) override;
   bool CanCreateWindow(const GURL& opener_url,
                        const GURL& opener_top_level_frame_url,
@@ skipping 121 matching lines @@
   std::vector<ChromeContentBrowserClientParts*> extra_parts_;
 
   base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_