Issue 750583002: Revert of Add MultiPictureDraw to nanobench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 750583002: Revert of Add MultiPictureDraw to nanobench (Closed)

Created:
6 years, 1 month ago by robertphillips

Modified:
6 years, 1 month ago

Reviewers:
mtklein, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Add MultiPictureDraw to nanobench (patchset #7 id:120001 of https://codereview.chromium.org/731973005/) Reason for revert: Needs more work Original issue's description: > Add MultiPictureDraw to nanobench > > I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium. > > TBR=bsalomon@google.com > > Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe TBR=mtklein@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/e77dadd91ae6f4319c2c047e7e36cc79bb4d1eff

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -175 lines)			Patch
M	bench/Benchmark.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	bench/Benchmark.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	bench/SKPBench.h	View	2 chunks	+6 lines, -14 lines	0 comments	Download
M	bench/SKPBench.cpp	View	3 chunks	+14 lines, -90 lines	0 comments	Download
M	bench/nanobench.cpp	View	10 chunks	+19 lines, -54 lines	0 comments	Download
M	include/core/SkColorTable.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmap.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkColorTable.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Add MultiPictureDraw to nanobench

6 years, 1 month ago (2014-11-21 13:49:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750583002/1

6 years, 1 month ago (2014-11-21 13:50:03 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-21 13:50:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e77dadd91ae6f4319c2c047e7e36cc79bb4d1eff