Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 750543002: Rip out bzip compression for native sources. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
4 years, 2 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : BUILD.gn #

Patch Set 3 : compressed_size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -386 lines) Patch
M BUILD.gn View 1 6 chunks +0 lines, -17 lines 0 comments Download
M build/features.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M include/v8.h View 1 2 2 chunks +1 line, -55 lines 0 comments Download
M samples/process.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M samples/shell.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M src/d8.cc View 3 chunks +0 lines, -41 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/mksnapshot.cc View 4 chunks +1 line, -72 lines 0 comments Download
M src/snapshot.h View 1 chunk +0 lines, -15 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +0 lines, -19 lines 0 comments Download
M tools/js2c.py View 3 chunks +4 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Yang
6 years, 1 month ago (2014-11-21 11:42:18 UTC) #1
vogelheim1
lgtm - provided caveats below are solved. I think this may be missing two cases: ...
6 years, 1 month ago (2014-11-21 11:50:50 UTC) #3
vogelheim1
On 2014/11/21 11:50:50, vogelheim1 wrote: > lgtm - provided caveats below are solved. > > ...
6 years, 1 month ago (2014-11-21 11:51:10 UTC) #4
Yang
On 2014/11/21 11:51:10, vogelheim1 wrote: > On 2014/11/21 11:50:50, vogelheim1 wrote: > > lgtm - ...
6 years, 1 month ago (2014-11-21 11:54:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750543002/20001
6 years, 1 month ago (2014-11-21 11:54:47 UTC) #7
vogelheim1
On 2014/11/21 11:54:05, Yang wrote: > On 2014/11/21 11:51:10, vogelheim1 wrote: > > On 2014/11/21 ...
6 years, 1 month ago (2014-11-21 12:02:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/44)
6 years, 1 month ago (2014-11-21 12:07:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750543002/40001
6 years, 1 month ago (2014-11-21 12:17:09 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-21 12:45:16 UTC) #13
jb.seo
4 years, 2 months ago (2016-10-12 08:12:09 UTC) #15
Message was sent while issue was closed.
Hello, vogelheim.

It's old thread. But,
can I ask why this happens?

I think the compression gives benefit in some cases.
Is there any reason to rip out the compression related codes?

Powered by Google App Engine
This is Rietveld 408576698