Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 750353004: Revert of Moves code from chromeos/ime to ui/base/ime/chromeos. (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Moves code from chromeos/ime to ui/base/ime/chromeos. (patchset #18 id:340001 of https://codereview.chromium.org/727143002/) Reason for revert: fails to compile on Linux ChromiumOS GN clang: error: no such file or directory: '../../chromeos/ime/mock_component_extension_ime_manager_delegate.cc' Original issue's description: > Moves code from chromeos/ime to ui/base/ime/chromeos. > > This is because the code under chromeos/ime has inappropriate dependencies to src/ui. > This cl doesn't include any logic changes in code, and only contains changes of moving files, changing includes, and necessary changes in GYPs and build rules. > > Note: > 1) the input_methods.txt & gen_input_methods.py remain unchanged because auto-test requires input_methods.txt file to be available, and input_method_whitelist needs the generated input_methods.h for compile. It could be moved in later CLs. > 2) We've been discussing the naming for ui/chromeos/ime, which could be renamed to something for "views". It can be done in a separated cl. > > TBR=sky@chromium.org > BUG=431863 > TEST=Verified on linux_chromeos. > > Committed: https://crrev.com/9917a3671cafa9d31a071a530b9ce10ce0661bc9 > Cr-Commit-Position: refs/heads/master@{#305964} TBR=yukishiino@chromium.org,stevenjb@chromium.org,sky@chromium.org,mukai@chromium.org,pkasting@chromium.org,derat@chromium.org,shuchen@chromium.org NOTREECHECKS=true NOTRY=true BUG=431863 Committed: https://crrev.com/857735b6255938981bf2dec4aee80e7bc6523631 Cr-Commit-Position: refs/heads/master@{#305965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3068 lines, -3026 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/tray_caps_lock.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/base/locale_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/system_key_event_listener.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen_input_methods_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/BUILD.gn View 2 chunks +15 lines, -0 lines 0 comments Download
M chromeos/DEPS View 2 chunks +4 lines, -3 lines 0 comments Download
M chromeos/chromeos.gyp View 6 chunks +50 lines, -0 lines 0 comments Download
A chromeos/ime/component_extension_ime_manager.h View 1 chunk +131 lines, -0 lines 0 comments Download
A chromeos/ime/component_extension_ime_manager.cc View 1 chunk +240 lines, -0 lines 0 comments Download
A chromeos/ime/component_extension_ime_manager_unittest.cc View 1 chunk +209 lines, -0 lines 0 comments Download
A chromeos/ime/composition_text.h View 1 chunk +70 lines, -0 lines 0 comments Download
A chromeos/ime/composition_text.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A chromeos/ime/composition_text_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A chromeos/ime/extension_ime_util.h View 1 chunk +100 lines, -0 lines 0 comments Download
A chromeos/ime/extension_ime_util.cc View 1 chunk +132 lines, -0 lines 0 comments Download
A chromeos/ime/extension_ime_util_unittest.cc View 1 chunk +87 lines, -0 lines 0 comments Download
A chromeos/ime/fake_ime_keyboard.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chromeos/ime/fake_ime_keyboard.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A chromeos/ime/fake_input_method_delegate.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chromeos/ime/fake_input_method_delegate.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M chromeos/ime/gen_input_methods.py View 1 chunk +0 lines, -2 lines 0 comments Download
A chromeos/ime/ime_keyboard.h View 1 chunk +126 lines, -0 lines 0 comments Download
A chromeos/ime/ime_keyboard.cc View 1 chunk +105 lines, -0 lines 0 comments Download
A chromeos/ime/ime_keyboard_ozone.h View 1 chunk +40 lines, -0 lines 0 comments Download
A chromeos/ime/ime_keyboard_ozone.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A chromeos/ime/ime_keyboard_x11.h View 1 chunk +93 lines, -0 lines 0 comments Download
A chromeos/ime/ime_keyboard_x11.cc View 1 chunk +299 lines, -0 lines 0 comments Download
A chromeos/ime/ime_keyboard_x11_unittest.cc View 1 chunk +156 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_delegate.h View 1 chunk +46 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_descriptor.h View 1 chunk +92 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_descriptor.cc View 1 chunk +62 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_manager.h View 1 chunk +242 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_manager.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_whitelist.h View 1 chunk +46 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_whitelist.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A chromeos/ime/input_method_whitelist_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A chromeos/ime/mock_component_extension_ime_manager_delegate.h View 1 chunk +63 lines, -0 lines 0 comments Download
A chromeos/ime/mock_component_extension_ime_manager_delegate.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +1 line, -22 lines 0 comments Download
M ui/base/ime/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D ui/base/ime/chromeos/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/base/ime/chromeos/component_extension_ime_manager.h View 1 chunk +0 lines, -131 lines 0 comments Download
D ui/base/ime/chromeos/component_extension_ime_manager.cc View 1 chunk +0 lines, -240 lines 0 comments Download
D ui/base/ime/chromeos/component_extension_ime_manager_unittest.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D ui/base/ime/chromeos/composition_text.h View 1 chunk +0 lines, -70 lines 0 comments Download
D ui/base/ime/chromeos/composition_text.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/base/ime/chromeos/composition_text_unittest.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/base/ime/chromeos/extension_ime_util.h View 1 chunk +0 lines, -100 lines 0 comments Download
D ui/base/ime/chromeos/extension_ime_util.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D ui/base/ime/chromeos/extension_ime_util_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/base/ime/chromeos/fake_ime_keyboard.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/base/ime/chromeos/fake_ime_keyboard.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/base/ime/chromeos/fake_input_method_delegate.h View 1 chunk +0 lines, -66 lines 0 comments Download
D ui/base/ime/chromeos/fake_input_method_delegate.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D ui/base/ime/chromeos/ime_keyboard.h View 1 chunk +0 lines, -126 lines 0 comments Download
D ui/base/ime/chromeos/ime_keyboard.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D ui/base/ime/chromeos/ime_keyboard_ozone.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/base/ime/chromeos/ime_keyboard_ozone.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/base/ime/chromeos/ime_keyboard_x11.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/base/ime/chromeos/ime_keyboard_x11.cc View 1 chunk +0 lines, -306 lines 0 comments Download
D ui/base/ime/chromeos/ime_keyboard_x11_unittest.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D ui/base/ime/chromeos/input_method_delegate.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/base/ime/chromeos/input_method_descriptor.h View 1 chunk +0 lines, -92 lines 0 comments Download
D ui/base/ime/chromeos/input_method_descriptor.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D ui/base/ime/chromeos/input_method_manager.h View 1 chunk +0 lines, -242 lines 0 comments Download
D ui/base/ime/chromeos/input_method_manager.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/base/ime/chromeos/input_method_whitelist.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/base/ime/chromeos/input_method_whitelist.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/base/ime/chromeos/mock_component_extension_ime_manager_delegate.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ui/base/ime/chromeos/mock_component_extension_ime_manager_delegate.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_input_context_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/chromeos/mock_ime_input_context_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base.gyp View 2 chunks +6 lines, -25 lines 0 comments Download
M ui/base/ui_base_tests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/chromeos/ime/candidate_view.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Moves code from chromeos/ime to ui/base/ime/chromeos.
6 years ago (2014-11-27 07:57:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750353004/1
6 years ago (2014-11-27 07:58:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-27 08:00:06 UTC) #3
commit-bot: I haz the power
6 years ago (2014-11-27 08:00:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/857735b6255938981bf2dec4aee80e7bc6523631
Cr-Commit-Position: refs/heads/master@{#305965}

Powered by Google App Engine
This is Rietveld 408576698