Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 75028: Don't call COM stuff in the renderer... (Closed)

Created:
11 years, 8 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't call COM stuff in the renderer - Remove calls to CoInitialize / CoUninitialize - CoUninitialize sometimes causes the OS to try to load oleauth.dll - An exception for in-process-plugins. BUG=10589 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13866

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/renderer/render_thread.cc View 2 chunks +6 lines, -8 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
11 years, 8 months ago (2009-04-16 03:28:34 UTC) #1
jam
lgtm http://codereview.chromium.org/75028/diff/1/2 File chrome/renderer/render_thread.cc (right): http://codereview.chromium.org/75028/diff/1/2#newcode104 Line 104: // The renderer thread should wind-up COM, ...
11 years, 8 months ago (2009-04-16 03:31:40 UTC) #2
darin (slow to review)
LGTM w/ John's suggested wording change.
11 years, 8 months ago (2009-04-16 15:08:17 UTC) #3
cpu_(ooo_6.6-7.5)
11 years, 8 months ago (2009-04-16 19:34:43 UTC) #4
Changes done and committed.

On 2009/04/16 15:08:17, darin wrote:
> LGTM w/ John's suggested wording change.

Powered by Google App Engine
This is Rietveld 408576698