Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 750263002: Fix implicit conversion of scoped_refptr<T> to T* in components/nacl (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix implicit conversion of scoped_refptr<T> to T* in components/nacl Since it's generally an anti-pattern to keep a pointer to a MessageLoopProxy without ref'ing it, the message_loop_ member is now a scoped_refptr<T>. BUG=110610 Committed: https://crrev.com/df07d905b283b05c3461d55bff06142ec6b8a2c4 Cr-Commit-Position: refs/heads/master@{#305466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M components/nacl/common/nacl_debug_exception_handler_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/common/nacl_debug_exception_handler_win.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years ago (2014-11-24 18:12:27 UTC) #2
Mark Seaborn
LGTM
6 years ago (2014-11-24 18:27:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750263002/1
6 years ago (2014-11-24 18:30:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 19:13:56 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-24 19:16:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df07d905b283b05c3461d55bff06142ec6b8a2c4
Cr-Commit-Position: refs/heads/master@{#305466}

Powered by Google App Engine
This is Rietveld 408576698