Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5044)

Unified Diff: components/nacl/common/nacl_debug_exception_handler_win.cc

Issue 750263002: Fix implicit conversion of scoped_refptr<T> to T* in components/nacl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/common/nacl_debug_exception_handler_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/common/nacl_debug_exception_handler_win.cc
diff --git a/components/nacl/common/nacl_debug_exception_handler_win.cc b/components/nacl/common/nacl_debug_exception_handler_win.cc
index 98198699af5e6081df1dd8e0d173975a55c6bde5..fdf4a590397b48986036b6ea43d5d2bff1557976 100644
--- a/components/nacl/common/nacl_debug_exception_handler_win.cc
+++ b/components/nacl/common/nacl_debug_exception_handler_win.cc
@@ -13,15 +13,15 @@ namespace {
class DebugExceptionHandler : public base::PlatformThread::Delegate {
public:
- DebugExceptionHandler(base::ProcessHandle nacl_process,
- const std::string& startup_info,
- base::MessageLoopProxy* message_loop,
- const base::Callback<void(bool)>& on_connected)
+ DebugExceptionHandler(
+ base::ProcessHandle nacl_process,
+ const std::string& startup_info,
+ const scoped_refptr<base::MessageLoopProxy>& message_loop,
+ const base::Callback<void(bool)>& on_connected)
: nacl_process_(nacl_process),
startup_info_(startup_info),
message_loop_(message_loop),
- on_connected_(on_connected) {
- }
+ on_connected_(on_connected) {}
virtual void ThreadMain() override {
// In the Windows API, the set of processes being debugged is
@@ -54,7 +54,7 @@ class DebugExceptionHandler : public base::PlatformThread::Delegate {
private:
base::win::ScopedHandle nacl_process_;
std::string startup_info_;
- base::MessageLoopProxy* message_loop_;
+ const scoped_refptr<base::MessageLoopProxy> message_loop_;
base::Callback<void(bool)> on_connected_;
DISALLOW_COPY_AND_ASSIGN(DebugExceptionHandler);
@@ -65,7 +65,7 @@ class DebugExceptionHandler : public base::PlatformThread::Delegate {
void NaClStartDebugExceptionHandlerThread(
base::ProcessHandle nacl_process,
const std::string& startup_info,
- base::MessageLoopProxy* message_loop,
+ const scoped_refptr<base::MessageLoopProxy>& message_loop,
const base::Callback<void(bool)>& on_connected) {
// The new PlatformThread will take ownership of the
// DebugExceptionHandler object, which will delete itself on exit.
« no previous file with comments | « components/nacl/common/nacl_debug_exception_handler_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698