Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: webkit/glue/plugins/webplugin_delegate_impl.cc

Issue 75026: Ensure we check the page pointer before using it after we come out of NPP_Han... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/plugins/webplugin_delegate_impl.cc
===================================================================
--- webkit/glue/plugins/webplugin_delegate_impl.cc (revision 13823)
+++ webkit/glue/plugins/webplugin_delegate_impl.cc (working copy)
@@ -220,7 +220,11 @@
}
void WebPluginDelegateImpl::PluginDestroyed() {
- delete this;
+ if (handle_event_depth_) {
ananta 2009/04/16 16:37:24 Would we run into the same issue with windowed plu
jam 2009/04/16 17:56:13 no since only windowless plugins would use HandleE
+ MessageLoop::current()->DeleteSoon(FROM_HERE, this);
+ } else {
+ delete this;
+ }
}
bool WebPluginDelegateImpl::Initialize(const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698