Ensure we check the page pointer before using it after we come out of NPP_Han...

webkit/glue/plugins/webplugin_delegate_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/plugins/webplugin_delegate_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_util.h"
@@ skipping 202 matching lines @@
 
   if (!windowless_)
     WindowedDestroyWindow();
 
   if (handle_event_pump_messages_event_) {
     CloseHandle(handle_event_pump_messages_event_);
   }
 }
 
 void WebPluginDelegateImpl::PluginDestroyed() {
-  delete this;
+  if (handle_event_depth_) {

[ananta, 2009/04/16 16:37:24]

Would we run into the same issue with windowed plugins?

[jam, 2009/04/16 17:56:13]

no since only windowless plugins would use HandleEvent

+    MessageLoop::current()->DeleteSoon(FROM_HERE, this);
+  } else {
+    delete this;
+  }
 }
 
 bool WebPluginDelegateImpl::Initialize(const GURL& url,
                                        char** argn,
                                        char** argv,
                                        int argc,
                                        WebPlugin* plugin,
                                        bool load_manually) {
   plugin_ = plugin;
 
@@ skipping 955 matching lines @@
 
   // It is ok to pass NULL here to GetCursor as we are not looking for cursor
   // types defined by Webkit.
   HCURSOR previous_cursor =
       g_current_plugin_instance->current_windowless_cursor_.GetCursor(NULL);
 
   g_current_plugin_instance->current_windowless_cursor_.InitFromExternalCursor(
       cursor);
   return previous_cursor;
 }