src/elements.h - Issue 750093003: Fix clang++ warnings on -Wtautological-constant-out-of-range-compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.h

Issue 750093003: Fix clang++ warnings on -Wtautological-constant-out-of-range-compare (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use static_cast instead of removing the DCHECK Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/elements.h

diff --git a/src/elements.h b/src/elements.h

index 9d86bbd657b5fde617ec05381de9e51cc06e1202..05354eaccf1359509ac6189fd5208b94620a0f09 100644

--- a/src/elements.h

+++ b/src/elements.h

@@ -179,7 +179,7 @@ class ElementsAccessor {

// Returns a shared ElementsAccessor for the specified ElementsKind.

static ElementsAccessor* ForKind(ElementsKind elements_kind) {

- DCHECK(elements_kind < kElementsKindCount);

+ DCHECK(static_cast<int>(elements_kind) < kElementsKindCount);

return elements_accessors_[elements_kind];

}

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »