src/objects.h - Issue 750093003: Fix clang++ warnings on -Wtautological-constant-out-of-range-compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 750093003: Fix clang++ warnings on -Wtautological-constant-out-of-range-compare (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use static_cast instead of removing the DCHECK Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index c284a49ea6dc5e56a96e077d41d48efdc6c9717c..d17d0d1ef1c851e08dca8eb5b1cfa8a812f04660 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -5739,7 +5739,7 @@ class Map: public HeapObject {

inline bool is_prototype_map();

inline void set_elements_kind(ElementsKind elements_kind) {

- DCHECK(elements_kind < kElementsKindCount);

+ DCHECK(static_cast<int>(elements_kind) < kElementsKindCount);

DCHECK(kElementsKindCount <= (1 << Map::ElementsKindBits::kSize));

set_bit_field2(Map::ElementsKindBits::update(bit_field2(), elements_kind));

DCHECK(this->elements_kind() == elements_kind);

« no previous file with comments | « src/elements.h ('k') | no next file » | no next file with comments »