Fix clang++ warnings on -Wtautological-constant-out-of-range-compare

Fix clang++ warnings on -Wtautological-constant-out-of-range-compare

BUG=v8:3730
LOG=N
R=dslomov@chromium.org

[Dmitry Lomov (no reviews), 2014-12-01 07:45:11]

On 2014/12/01 03:04:58, haltonhuo wrote:

not lgtm

we do cast from/to ElementsKind a lot in V8's code base. Both those DCHECKs are
last line of defense against somebody getting it wrong.

[Sven Panne, 2014-12-01 07:49:50]

On 2014/12/01 07:45:11, Dmitry Lomov (chromium) wrote:
> On 2014/12/01 03:04:58, haltonhuo wrote:
> 
> not lgtm
> 
> we do cast from/to ElementsKind a lot in V8's code base. Both those DCHECKs
are
> last line of defense against somebody getting it wrong.

It would be interesting to know the exact compiler version which complains. This
"last line of defense" is of course optimized away by that compiler. :-)

[haltonhuo, 2014-12-01 07:51:34]

On 2014/12/01 07:45:11, Dmitry Lomov (chromium) wrote:
> On 2014/12/01 03:04:58, haltonhuo wrote:
> 
> not lgtm
> 
> we do cast from/to ElementsKind a lot in V8's code base. Both those DCHECKs
are
> last line of defense against somebody getting it wrong.

Thanks for review, then does adding static_cast<int> make sense to you? Same as
https://code.google.com/p/v8/source/detail?r=12792

[Dmitry Lomov (no reviews), 2014-12-01 07:52:57]

On 2014/12/01 07:51:34, haltonhuo wrote:
> On 2014/12/01 07:45:11, Dmitry Lomov (chromium) wrote:
> > On 2014/12/01 03:04:58, haltonhuo wrote:
> > 
> > not lgtm
> > 
> > we do cast from/to ElementsKind a lot in V8's code base. Both those DCHECKs
> are
> > last line of defense against somebody getting it wrong.
> 
> Thanks for review, then does adding static_cast<int> make sense to you? Same
as
> https://code.google.com/p/v8/source/detail?r=12792

Yes, that's better.

[haltonhuo, 2014-12-01 08:00:07]

On 2014/12/01 07:52:57, Dmitry Lomov (chromium) wrote:
> > Thanks for review, then does adding static_cast<int> make sense to you? Same
> as
> > https://code.google.com/p/v8/source/detail?r=12792
> 
> Yes, that's better.

Patch set2 is updated, please review.

[Dmitry Lomov (no reviews), 2014-12-01 08:12:47]

lgtm

[Dmitry Lomov (no reviews), 2014-12-01 08:13:08]

The CQ bit was checked by dslomov@chromium.org

[commit-bot: I haz the power, 2014-12-01 08:13:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/750093003/20001

[commit-bot: I haz the power, 2014-12-01 09:17:31]

Committed patchset #2 (id:20001)