Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 750013004: Added experimental tilt and tiltDirection to the Touch interface (Closed)

Created:
6 years ago by d.pikalov
Modified:
5 years, 7 months ago
Reviewers:
Rick Byers, adamk
CC:
blink-reviews, arv+blink, blink-reviews-events_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added experimental tilt and tiltDirection to the Touch interface Tilt reports the angle of the stylus in degrees, in range [0, 90). Currently available behind the enable-experimental-web-platform-features flag. TiltDirection is an clockwise angle [-180..180) in relation to the 0X axis. The angle indicates the direction in which the stylus is tilted. Draft spec: https://docs.google.com/document/d/1hRjHN9T3RBKJV6LL6WQMEaw35YD_T-G41X-ZciW18xU/edit A link to the Chrome patch (https://codereview.chromium.org/755403006/) BUG=393462

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Make Touch.tilt available behind the enable-experimental-web-platform-features flag #

Total comments: 4

Patch Set 4 : Fixed: tilt argument must be last (+ related changes) #

Patch Set 5 : Added Touch.tiltDirection #

Patch Set 6 : Added basic layout-tests for tilt, tiltDirection #

Total comments: 6

Patch Set 7 : webkit prefix(es) removed #

Patch Set 8 : Added NaN value support for tilt, tiltDirection #

Patch Set 9 : Added tests: Verify tilt, tiltDirection can be plumbed through correctly via eventSender #

Patch Set 10 : Merged with master #

Patch Set 11 : Keep eventSender.setTouchPointTilt under "if" + added 4th argument (set_state_moved) #

Total comments: 6

Patch Set 12 : Merged with master #

Patch Set 13 : fixed touch-tilt.html #

Patch Set 14 : Merged with master #

Patch Set 15 : Fixed WebInputEventConversionTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -26 lines) Patch
M LayoutTests/fast/events/touch/basic-single-touch-events-expected.txt View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/document-create-touch-expected.txt View 1 2 3 4 5 4 chunks +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/script-tests/basic-single-touch-events.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +17 lines, -8 lines 0 comments Download
M LayoutTests/fast/events/touch/script-tests/document-create-touch.js View 1 2 3 4 5 5 chunks +10 lines, -2 lines 0 comments Download
A LayoutTests/fast/events/touch/touch-tilt.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/touch/touch-tilt-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/dom/Touch.h View 1 2 3 4 5 6 7 8 9 4 chunks +8 lines, -4 lines 0 comments Download
M Source/core/dom/Touch.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -3 lines 0 comments Download
M Source/core/dom/Touch.idl View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PlatformTouchPoint.h View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +6 lines, -4 lines 0 comments Download
M public/web/WebTouchPoint.h View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 53 (23 generated)
Rick Byers
I'd love to be able to do this (see http://crbug.com/393462), but in general we don't ...
6 years ago (2014-11-26 18:57:34 UTC) #2
d.pikalov
On 2014/11/26 18:57:34, Rick Byers wrote: > I'd love to be able to do this ...
6 years ago (2014-11-28 14:08:32 UTC) #3
Rick Byers
On 2014/11/28 14:08:32, d.pikalov wrote: > On 2014/11/26 18:57:34, Rick Byers wrote: > > I'd ...
5 years, 10 months ago (2015-01-28 21:43:57 UTC) #4
d.pikalov
On 2015/01/28 21:43:57, Rick Byers wrote: > On 2014/11/28 14:08:32, d.pikalov wrote: > > On ...
5 years, 10 months ago (2015-01-30 11:50:09 UTC) #5
d.pikalov
Touch.tilt available behind the enable-experimental-web-platform-features flag
5 years, 10 months ago (2015-02-04 11:08:23 UTC) #7
Rick Byers
This looks reasonable overall. But you're going to change it to use the new API ...
5 years, 10 months ago (2015-02-04 11:48:56 UTC) #8
d.pikalov
> This looks reasonable overall. But you're going to change it to use the new ...
5 years, 10 months ago (2015-02-04 13:39:41 UTC) #9
d.pikalov
https://codereview.chromium.org/750013004/diff/60001/Source/core/dom/Document.idl File Source/core/dom/Document.idl (right): https://codereview.chromium.org/750013004/diff/60001/Source/core/dom/Document.idl#newcode194 Source/core/dom/Document.idl:194: [Default=Undefined] optional float webkitTilt, On 2015/02/04 11:48:55, Rick Byers ...
5 years, 10 months ago (2015-02-11 11:17:13 UTC) #10
d.pikalov
On 2015/02/04 13:39:41, d.pikalov wrote: > > It's probably worth having a simple doc somewhere ...
5 years, 10 months ago (2015-02-11 11:22:49 UTC) #11
Rick Byers
On 2015/02/11 11:22:49, d.pikalov wrote: > On 2015/02/04 13:39:41, d.pikalov wrote: > > > > ...
5 years, 10 months ago (2015-02-13 08:34:36 UTC) #12
Rick Byers
This looks almost ready to land to me. I updated your description to add the ...
5 years, 10 months ago (2015-02-13 08:48:05 UTC) #13
d.pikalov
https://codereview.chromium.org/750013004/diff/120001/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/750013004/diff/120001/Source/core/dom/Document.cpp#newcode5151 Source/core/dom/Document.cpp:5151: tilt = 0; On 2015/02/13 08:48:05, Rick Byers wrote: ...
5 years, 10 months ago (2015-02-13 13:31:17 UTC) #14
d.pikalov
> Can you please enable comments? Sure, done > My only suggestion is that perhaps ...
5 years, 10 months ago (2015-02-13 14:50:29 UTC) #15
Rick Byers
Sorry for the delay, I didn't realize you had uploaded your new patchset. There's one ...
5 years, 10 months ago (2015-02-19 17:24:57 UTC) #23
Rick Byers
BTW, I added a link to your draft spec to the CL description.
5 years, 10 months ago (2015-02-19 17:25:41 UTC) #24
d.pikalov
5 years, 9 months ago (2015-03-05 14:33:34 UTC) #25
d.pikalov
Keep eventSender.setTouchPointTilt under "if", until chrome patch landed. Added 4th argument (set_state_moved)
5 years, 9 months ago (2015-03-17 11:08:19 UTC) #26
Rick Byers
LGTM with nits https://codereview.chromium.org/750013004/diff/220001/LayoutTests/fast/events/touch/touch-tilt.html File LayoutTests/fast/events/touch/touch-tilt.html (right): https://codereview.chromium.org/750013004/diff/220001/LayoutTests/fast/events/touch/touch-tilt.html#newcode12 LayoutTests/fast/events/touch/touch-tilt.html:12: touch = event.touches.item(0); nit: touches is ...
5 years, 9 months ago (2015-03-17 14:38:48 UTC) #27
d.pikalov
Test touch-tilt fixed https://codereview.chromium.org/750013004/diff/220001/LayoutTests/fast/events/touch/touch-tilt.html File LayoutTests/fast/events/touch/touch-tilt.html (right): https://codereview.chromium.org/750013004/diff/220001/LayoutTests/fast/events/touch/touch-tilt.html#newcode12 LayoutTests/fast/events/touch/touch-tilt.html:12: touch = event.touches.item(0); On 2015/03/17 14:38:48, ...
5 years, 9 months ago (2015-03-17 16:15:51 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750013004/280001
5 years, 9 months ago (2015-03-18 13:48:00 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/48034)
5 years, 9 months ago (2015-03-18 13:51:19 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750013004/300001
5 years, 9 months ago (2015-03-18 14:38:01 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/29275)
5 years, 9 months ago (2015-03-18 14:44:04 UTC) #40
d.pikalov
5 years, 9 months ago (2015-03-18 14:48:38 UTC) #42
d.pikalov
On 2015/03/18 14:48:38, d.pikalov wrote: +adamk, please review
5 years, 9 months ago (2015-03-18 14:50:39 UTC) #43
adamk
lgtm for Source/web and Source/platform (rbyers, strangely enough, is in public/OWNERS but not Source/web/OWNERS).
5 years, 9 months ago (2015-03-18 15:56:38 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750013004/300001
5 years, 9 months ago (2015-03-18 16:05:18 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/29870)
5 years, 9 months ago (2015-03-18 16:25:10 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750013004/320001
5 years, 9 months ago (2015-03-19 11:32:59 UTC) #51
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:47:25 UTC) #53
Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

Powered by Google App Engine
This is Rietveld 408576698