Issue 7500002: Remove the compact nav flag and ensure it is always disabled. Note that the rest of the cnav code...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7500002: Remove the compact nav flag and ensure it is always disabled. Note that the rest of the cnav code... (Closed)

Created:
9 years, 5 months ago by SteveT

Modified:
9 years, 5 months ago

Reviewers:
MAD, commit-bot: I haz the power

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove the compact nav flag and ensure it is always disabled. Note that the rest of the cnav code remains for now. TEST=Ensure that about:flags no longer has an entry fo compact nav, and that the feature is completely inaccessible (can't be activated from tab context menu). BUG=89162

Patch Set 1 : '' #

Patch Set 2 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -25 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/tabs/tab_menu_model.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

MAD

Since we removed the switch string as well as the flag, we could also remove ...

9 years, 5 months ago (2011-07-25 19:55:39 UTC) #2

commit-bot: I haz the power

9 years, 5 months ago (2011-07-26 21:09:47 UTC) #3

Commit queue had an internal error.
Something went really wrong, probably a crash, a hickup or
simply the monkeys went out for diner.
The relevant dude was pinged already.

Expand Messages | Collapse Messages