Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 7500002: Remove the compact nav flag and ensure it is always disabled. Note that the rest of the cnav code... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/tabs/tab_menu_model.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
===================================================================
--- chrome/browser/ui/views/frame/browser_view.cc (revision 93878)
+++ chrome/browser/ui/views/frame/browser_view.cc (working copy)
@@ -1991,11 +1991,15 @@
browser_->tabstrip_model()->AddObserver(aeropeek_manager_.get());
}
#endif
+ // TODO(stevet): Remove all of this once we clean up compact navigation. Note
+ // that we revert back to checking the pref as we've guaranteed that it will
+ // always return false, regardless of flags.
// Only create our compact navigation classes if the switch is enabled. Note
// that we directly check the switch and not the pref as the switch may be on
// and the pref could be off (currently not selected in the context menu).
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableCompactNavigation)) {
+ // if (CommandLine::ForCurrentProcess()->HasSwitch(
+ // switches::kEnableCompactNavigation)) {
+ if (UseCompactNavigationBar()) {
compact_location_bar_view_host_.reset(new CompactLocationBarViewHost(this));
compact_navigation_bar_ = new CompactNavigationBar(this);
compact_navigation_bar_->set_id(VIEW_ID_COMPACT_NAV_BAR);
« no previous file with comments | « chrome/browser/ui/tabs/tab_menu_model.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698