Source/platform/graphics/gpu/DrawingBuffer.h - Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/gpu/DrawingBuffer.h

Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/graphics/ImageBuffer.cpp ('k') | Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | Source/platform/graphics/gpu/DrawingBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/gpu/DrawingBuffer.h

diff --git a/Source/platform/graphics/gpu/DrawingBuffer.h b/Source/platform/graphics/gpu/DrawingBuffer.h

index c28f68f73e4e596bfee445175ab8ab8a0e2f586b..7e0ce034009498746e5594c79e02820bf1c8fe98 100644

--- a/Source/platform/graphics/gpu/DrawingBuffer.h

+++ b/Source/platform/graphics/gpu/DrawingBuffer.h

@@ -155,15 +155,14 @@ public:

virtual bool prepareMailbox(WebExternalTextureMailbox*, WebExternalBitmap*) override;

virtual void mailboxReleased(const WebExternalTextureMailbox&, bool lostResource = false) override;

- enum SourceBuffer { Front, Back };

// Destroys the TEXTURE_2D binding for the owned context

bool copyToPlatformTexture(WebGraphicsContext3D*, Platform3DObject texture, GLenum internalFormat,

- GLenum destType, GLint level, bool premultiplyAlpha, bool flipY, SourceBuffer);

+ GLenum destType, GLint level, bool premultiplyAlpha, bool flipY, SourceDrawingBuffer);

void setPackAlignment(GLint param);

void paintRenderingResultsToCanvas(ImageBuffer*);

- PassRefPtr<Uint8ClampedArray> paintRenderingResultsToImageData(int&, int&);

+ PassRefPtr<Uint8ClampedArray> paintRenderingResultsToImageData(int&, int&, SourceDrawingBuffer);

protected: // For unittests

DrawingBuffer(