Source/platform/graphics/ImageBuffer.cpp - Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/ImageBuffer.cpp

Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/graphics/ImageBuffer.h ('k') | Source/platform/graphics/gpu/DrawingBuffer.h » ('j') | Source/platform/graphics/gpu/DrawingBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/ImageBuffer.cpp

diff --git a/Source/platform/graphics/ImageBuffer.cpp b/Source/platform/graphics/ImageBuffer.cpp

index 635dde71a1163b85205a4f1f4ba06401470e3f0f..9b073d51f63a3e368e39f5b2207b5d96dc781101 100644

--- a/Source/platform/graphics/ImageBuffer.cpp

+++ b/Source/platform/graphics/ImageBuffer.cpp

@@ -242,7 +242,7 @@ void ImageBuffer::didModifyBackingTexture()

m_surface->didModifyBackingTexture();

}

-bool ImageBuffer::copyRenderingResultsFromDrawingBuffer(DrawingBuffer* drawingBuffer, bool fromFrontBuffer)

+bool ImageBuffer::copyRenderingResultsFromDrawingBuffer(DrawingBuffer* drawingBuffer, SourceDrawingBuffer sourceBuffer)

{

if (!drawingBuffer)

return false;

@@ -256,7 +256,7 @@ bool ImageBuffer::copyRenderingResultsFromDrawingBuffer(DrawingBuffer* drawingBu

m_surface->invalidateCachedBitmap();

bool result = drawingBuffer->copyToPlatformTexture(context3D, tex, GL_RGBA,

- GL_UNSIGNED_BYTE, 0, true, false, fromFrontBuffer ? DrawingBuffer::Front : DrawingBuffer::Back);

+ GL_UNSIGNED_BYTE, 0, true, false, sourceBuffer);

if (result) {

m_surface->didModifyBackingTexture();

« no previous file with comments | « Source/platform/graphics/ImageBuffer.h ('k') | Source/platform/graphics/gpu/DrawingBuffer.h » ('j') | Source/platform/graphics/gpu/DrawingBuffer.cpp » ('J')