Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 749603002: Revert of Refoctoring FileSelection and FileSelectionHandler. (Closed)

Created:
6 years, 1 month ago by Mark P
Modified:
6 years, 1 month ago
Reviewers:
hirono, fukino, sky
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Refoctoring FileSelection and FileSelectionHandler. (patchset #9 id:150001 of https://codereview.chromium.org/736663002/) Reason for revert: Causing failures on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 SelectFileAndOpen SelectFileAndSave NOTRY=true TBR=hirono [detailed omitted; should've been sent by e-mail] Committed: https://crrev.com/ed1db2487e833555b0a9862540a1fe44e225959b Cr-Commit-Position: refs/heads/master@{#305121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -160 lines) Patch
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/dialog_action_controller.js View 3 chunks +14 lines, -13 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 3 chunks +2 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 2 chunks +18 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_selection.js View 6 chunks +35 lines, -134 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/share_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Mark P
Created Revert of Refoctoring FileSelection and FileSelectionHandler.
6 years, 1 month ago (2014-11-20 20:21:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749603002/1
6 years, 1 month ago (2014-11-20 20:22:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749603002/1
6 years, 1 month ago (2014-11-21 00:28:26 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-21 00:28:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749603002/1
6 years, 1 month ago (2014-11-21 00:31:26 UTC) #11
agable
On 2014/11/21 at 00:31:26, commit-bot wrote: > CQ is trying da patch. Follow status at ...
6 years, 1 month ago (2014-11-21 00:32:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749603002/1
6 years, 1 month ago (2014-11-21 00:33:20 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 00:34:55 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 00:35:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed1db2487e833555b0a9862540a1fe44e225959b
Cr-Commit-Position: refs/heads/master@{#305121}

Powered by Google App Engine
This is Rietveld 408576698