ui/file_manager/file_manager/foreground/js/file_manager.js - Issue 749603002: Revert of Refoctoring FileSelection and FileSelectionHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 749603002: Revert of Refoctoring FileSelection and FileSelectionHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/dialog_action_controller.js ('k') | ui/file_manager/file_manager/foreground/js/file_manager_commands.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/file_manager.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js

index 6f5d831820e96db7dc9789acf62e1692a151b357..08ae7cee9b0a648e68b418c89926014f23b39d15 100644

--- a/ui/file_manager/file_manager/foreground/js/file_manager.js

+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js

@@ -383,12 +383,6 @@

get historyLoader() {

return this.historyLoader_;

- },

- /**

- * @return {MetadataCache}

- */

- get metadataCache() {

- return this.metadataCache_;

/**

* @return {FileManagerUI}

@@ -1811,7 +1805,7 @@

var entry = selection.entries[0];

if (entry.isDirectory) {

- this.onDirectoryAction_(/** @type {!DirectoryEntry} */(entry));

+ this.onDirectoryAction_(entry);

} else {

this.dispatchSelectionAction_();

}

@@ -2196,8 +2190,7 @@

// directory.

if (!item.hasAttribute('renaming')) {

event.preventDefault();

- this.onDirectoryAction_(

- /** @type {DirectoryEntry} */(selection.entries[0]));

+ this.onDirectoryAction_(selection.entries[0]);

}

} else if (this.dispatchSelectionAction_()) {

event.preventDefault();