Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 74953002: Revert 235595 "Revert 235492 "[sql] Recover Favicons v5 database..." (Closed)

Created:
7 years, 1 month ago by kinuko
Modified:
7 years, 1 month ago
Reviewers:
kinuko
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 235595 "Revert 235492 "[sql] Recover Favicons v5 database..." > Revert 235492 "[sql] Recover Favicons v5 databases, with more re..." > > Speculative revert to find the cause for Mac size regression > (will revert this revert later) > > > [sql] Recover Favicons v5 databases, with more recovery automation. > > > > An entirely automated recovery system runs afoul of questions about > > whether the corrupt database's schema can be trusted. > > sql::Recovery::AutoRecoverTable() uses a schema created by the caller > > to construct the recovery virtual table and then copies the data over. > > > > sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify > > accessing meta-table info in the corrupt database. > > > > sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to > > simplify common testing operations. > > > > Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using > > these changes, and add a v5 recovery path. Additionally handle > > deprecated versions. > > > > BUG=240396, 109482 > > > > Review URL: https://codereview.chromium.org/50493012 > > TBR=shess@chromium.org > > Review URL: https://codereview.chromium.org/74933002 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+909 lines, -246 lines) Patch
M trunk/src/chrome/browser/history/thumbnail_database.cc View 4 chunks +177 lines, -175 lines 0 comments Download
M trunk/src/chrome/browser/history/thumbnail_database_unittest.cc View 6 chunks +61 lines, -50 lines 0 comments Download
M trunk/src/sql/connection_unittest.cc View 2 chunks +3 lines, -20 lines 0 comments Download
M trunk/src/sql/recovery.h View 1 chunk +40 lines, -0 lines 0 comments Download
M trunk/src/sql/recovery.cc View 2 chunks +174 lines, -0 lines 0 comments Download
M trunk/src/sql/recovery_unittest.cc View 3 chunks +331 lines, -1 line 0 comments Download
M trunk/src/sql/test/test_helpers.h View 3 chunks +17 lines, -0 lines 0 comments Download
M trunk/src/sql/test/test_helpers.cc View 2 chunks +71 lines, -0 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kinuko
7 years, 1 month ago (2013-11-18 04:18:26 UTC) #1
kinuko
7 years, 1 month ago (2013-11-18 04:18:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r235604.

Powered by Google App Engine
This is Rietveld 408576698