Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 74933002: Revert 235492 "[sql] Recover Favicons v5 databases, with more re..." (Closed)

Created:
7 years, 1 month ago by kinuko
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 235492 "[sql] Recover Favicons v5 databases, with more re..." Speculative revert to find the cause for Mac size regression (will revert this revert later) > [sql] Recover Favicons v5 databases, with more recovery automation. > > An entirely automated recovery system runs afoul of questions about > whether the corrupt database's schema can be trusted. > sql::Recovery::AutoRecoverTable() uses a schema created by the caller > to construct the recovery virtual table and then copies the data over. > > sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify > accessing meta-table info in the corrupt database. > > sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to > simplify common testing operations. > > Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using > these changes, and add a v5 recovery path. Additionally handle > deprecated versions. > > BUG=240396, 109482 > > Review URL: https://codereview.chromium.org/50493012 TBR=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -909 lines) Patch
M trunk/src/chrome/browser/history/thumbnail_database.cc View 4 chunks +175 lines, -177 lines 0 comments Download
M trunk/src/chrome/browser/history/thumbnail_database_unittest.cc View 6 chunks +50 lines, -61 lines 0 comments Download
M trunk/src/sql/connection_unittest.cc View 2 chunks +20 lines, -3 lines 0 comments Download
M trunk/src/sql/recovery.h View 1 chunk +0 lines, -40 lines 0 comments Download
M trunk/src/sql/recovery.cc View 2 chunks +0 lines, -174 lines 0 comments Download
M trunk/src/sql/recovery_unittest.cc View 3 chunks +1 line, -331 lines 0 comments Download
M trunk/src/sql/test/test_helpers.h View 3 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/sql/test/test_helpers.cc View 2 chunks +0 lines, -71 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
7 years, 1 month ago (2013-11-18 03:28:41 UTC) #1
kinuko
Committed patchset #1 manually as r235595.
7 years, 1 month ago (2013-11-18 03:28:59 UTC) #2
kinuko
On 2013/11/18 03:28:59, kinuko wrote: > Committed patchset #1 manually as r235595. Was a false ...
7 years, 1 month ago (2013-11-18 04:16:53 UTC) #3
Scott Hess - ex-Googler
7 years, 1 month ago (2013-11-18 18:08:44 UTC) #4
Message was sent while issue was closed.
On 2013/11/18 04:16:53, kinuko wrote:
> On 2013/11/18 03:28:59, kinuko wrote:
> > Committed patchset #1 manually as r235595.
> 
> Was a false alarm, reverting this revert.. sorry.

np - I was terrified that you'd find it really was correlated :-).

Powered by Google App Engine
This is Rietveld 408576698