Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: Source/core/page/ChromeClient.h

Issue 749333002: Plumbing for frame-specific WebWidgets (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed broken popup bug Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/ChromeClient.h
diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h
index c96c24d51fbcf0d38de9e643b7e15618a2da9b3e..2ce6969de7977162fdbc1f870c93a489fa1fabf6 100644
--- a/Source/core/page/ChromeClient.h
+++ b/Source/core/page/ChromeClient.h
@@ -141,6 +141,8 @@ public:
virtual void scheduleAnimation() = 0;
// End methods used by HostWindow.
+ virtual void scheduleAnimationForFrame(LocalFrame* rootFrame) { }
+
virtual void dispatchViewportPropertiesDidChange(const ViewportDescription&) const { }
virtual void contentsSizeChanged(LocalFrame*, const IntSize&) const = 0;
@@ -177,8 +179,10 @@ public:
// Allows ports to customize the type of graphics layers created by this page.
virtual GraphicsLayerFactory* graphicsLayerFactory() const { return nullptr; }
- // Pass 0 as the GraphicsLayer to detatch the root layer.
- virtual void attachRootGraphicsLayer(GraphicsLayer*) = 0;
+ // Pass 0 as the GraphicsLayer to detach the root layer.
+ // LocalFrame sets the graphics layer to that frame's WebWidget, and should be 0
dcheng 2014/11/24 22:30:39 s/to that/for that/
kenrb 2014/11/25 17:14:56 Done.
+ // for setting the graphics layer to a WebView or WebPopupView.
dcheng 2014/11/24 22:30:39 We don't seem to actually pass null for the LocalF
kenrb 2014/11/25 17:14:56 Changed.
+ virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) = 0;
virtual void enterFullScreenForElement(Element*) { }
virtual void exitFullScreenForElement(Element*) { }

Powered by Google App Engine
This is Rietveld 408576698