Issue 7491089: Make experimental/gc compilable on Mac OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7491089: Make experimental/gc compilable on Mac OS. (Closed)

Created:
9 years, 4 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 4 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/gc/

Visibility:
Public.

Description

Make experimental/gc compilable on Mac OS. Committed: http://code.google.com/p/v8/source/detail?r=8856

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -18 lines)			Patch
M	src/ia32/assembler-ia32.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/platform-linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-macos.cc	View	3 chunks	+43 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/7491089/diff/1/src/platform-macos.cc File src/platform-macos.cc (right): http://codereview.chromium.org/7491089/diff/1/src/platform-macos.cc#newcode352 src/platform-macos.cc:352: Not setting size_?

9 years, 4 months ago (2011-08-08 09:29:39 UTC) #2

Vyacheslav Egorov (Chromium)

9 years, 4 months ago (2011-08-08 10:00:53 UTC) #3

thanks! landed.

http://codereview.chromium.org/7491089/diff/1/src/platform-macos.cc
File src/platform-macos.cc (right):

http://codereview.chromium.org/7491089/diff/1/src/platform-macos.cc#newcode352
src/platform-macos.cc:352: 
On 2011/08/08 09:29:39, Lasse Reichstein wrote:
> Not setting size_?

This is a static method.

Expand Messages | Collapse Messages