remove childrenInline & setChildrenInline

setChildrenInline wasn't doing anything and childrenInlien always deferred to isRenderParagraph.

Also, add a test from the original webkit patch that called setChildrenInline in layoutBlock

R=ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/04fb12047dee4d7cdf5b06c87693e80ad0be4287

[rafaelw, 2014-11-21 22:45:19]

rafaelw@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2014-11-21 22:55:10]

lgtm

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
File sky/engine/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderBlock.cpp:1890: if (block->isRenderBlockFlow()
&& block->isRenderParagraph()) {
Nit: this is redundant. RenderParagraphs are always RenderBlockFlows.

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
File sky/engine/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderObject.cpp:1649: // isRenderParagraph() state
and our state.
This comment doesn't really make sense anymore since there's no state involved
anymore. Really, this function needs to be inlined (see FIXME a couple lines up)
and the comment deleted.

https://codereview.chromium.org/748943002/diff/40001/sky/tests/editing/delete...
File sky/tests/editing/delete_block_contents.sky (right):

https://codereview.chromium.org/748943002/diff/40001/sky/tests/editing/delete...
sky/tests/editing/delete_block_contents.sky:20:
internals.notifyTestComplete(elem.offsetHeight == originalHeight ? 'PASS' :
'FAIL: expected=' + originalHeight + ', actual=' + elen.offsetHeight);
This is fine. It'd be better if you used a mocha+chai test so that you could
write an actual assert here instead of a custom one.

[rafaelw, 2014-11-21 23:13:54]

all done

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
File sky/engine/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderBlock.cpp:1890: if (block->isRenderBlockFlow()
&& block->isRenderParagraph()) {
On 2014/11/21 22:55:10, ojan wrote:
> Nit: this is redundant. RenderParagraphs are always RenderBlockFlows.

Done.

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
File sky/engine/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/748943002/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderObject.cpp:1649: // isRenderParagraph() state
and our state.
On 2014/11/21 22:55:10, ojan wrote:
> This comment doesn't really make sense anymore since there's no state involved
> anymore. Really, this function needs to be inlined (see FIXME a couple lines
up)
> and the comment deleted.

Done.

[rafaelw, 2014-11-21 23:17:09]

Committed patchset #5 (id:80001) manually as
04fb12047dee4d7cdf5b06c87693e80ad0be4287.