sky/engine/core/dom/Text.cpp - Issue 748943002: remove childrenInline & setChildrenInline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/Text.cpp

Issue 748943002: remove childrenInline & setChildrenInline (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: cr comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/Text.cpp

diff --git a/sky/engine/core/dom/Text.cpp b/sky/engine/core/dom/Text.cpp

index 9ecdd2b054f5ef77fca792d8425f4d883c1dacae..18ee90a6c87de9ca598fce17405db084ef0c46eb 100644

--- a/sky/engine/core/dom/Text.cpp

+++ b/sky/engine/core/dom/Text.cpp

@@ -120,7 +120,7 @@ bool Text::textRendererIsNeeded(const RenderStyle& style, const RenderObject& pa

if (prev && !prev->isInline())

return false;

} else {

- if (parent.isRenderBlock() && !parent.childrenInline() && (!prev || !prev->isInline()))

+ if (parent.isRenderBlock() && !parent.isRenderParagraph() && (!prev || !prev->isInline()))

return false;

// Avoiding creation of a Renderer for the text node is a non-essential memory optimization.

« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »