Issue 748863004: Get rid of getCTM/setCTM pair in Font::paintGlyphsVertical

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 748863004: Get rid of getCTM/setCTM pair in Font::paintGlyphsVertical (Closed)

Created:
6 years ago by fs

Modified:
6 years ago

Reviewers:
f(malita), jbroman

CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Get rid of getCTM/setCTM pair in Font::paintGlyphsVertical GC::setCTM is not safe to use in the presence of active recordings, since it will end up accumulating the saved matrix on the currently active SkCanvas. Use a GCSS to save/restore the CTM instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186291

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	Source/platform/fonts/Font.cpp	View		3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748863004/1

6 years ago (2014-12-02 12:00:33 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-02 12:02:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186291

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages