tools/gn/command_format_unittest.cc - Issue 748863003: gn format: penalty-based scheme for line breaking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_format_unittest.cc

Issue 748863003: gn format: penalty-based scheme for line breaking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-more-disabled

Patch Set: x64 Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/command_format_unittest.cc

diff --git a/tools/gn/command_format_unittest.cc b/tools/gn/command_format_unittest.cc

index 6458179f21fa29f94b584c29603bac2ccbb52771..32b8fcebd1debc70aa119030d0c3649936c43c7c 100644

--- a/tools/gn/command_format_unittest.cc

+++ b/tools/gn/command_format_unittest.cc

@@ -66,13 +66,25 @@ FORMAT_TEST(028)

FORMAT_TEST(029)

FORMAT_TEST(030)

FORMAT_TEST(031)

-// TODO(scottmg): Continued conditions aren't aligned properly: FORMAT_TEST(032)

+FORMAT_TEST(032)

FORMAT_TEST(033)

// TODO(scottmg): args+rebase_path unnecessarily split: FORMAT_TEST(034)

FORMAT_TEST(035)

FORMAT_TEST(036)

-// TODO(scottmg): Ugly line breaking: FORMAT_TEST(037)

+FORMAT_TEST(037)

FORMAT_TEST(038)

-// TODO(scottmg): Bad break, exceeding 80 col: FORMAT_TEST(039)

+FORMAT_TEST(039)

// TODO(scottmg): Bad break, exceeding 80 col: FORMAT_TEST(040)

FORMAT_TEST(041)

+FORMAT_TEST(042)

+// TODO(scottmg): Unnecessary line break: FORMAT_TEST(043)

+// TODO(scottmg): Dewrapped caused exceeding 80 col: FORMAT_TEST(044)

+FORMAT_TEST(045)

+FORMAT_TEST(046)

+FORMAT_TEST(047)

+// TODO(scottmg): Unnecessary blank line inserted: FORMAT_TEST(048)

+// TODO(scottmg): Eval is broken (!) and comment output might have extra ,

+// FORMAT_TEST(049)

+FORMAT_TEST(050)

+FORMAT_TEST(051)

+// TODO(scottmg): Ugly separation: FORMAT_TEST(052)

« no previous file with comments | « tools/gn/command_format.cc ('k') | tools/gn/format_test_data/003.golden » ('j') | no next file with comments »