tools/gn/command_format_unittest.cc - Issue 748863003: gn format: penalty-based scheme for line breaking

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/command_format_unittest.cc

Issue 748863003: gn format: penalty-based scheme for line breaking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-more-disabled

Patch Set: x64 Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/files/file_util.h"	5 #include "base/files/file_util.h"

6 #include "base/strings/string_util.h"	6 #include "base/strings/string_util.h"

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8 #include "tools/gn/commands.h"	8 #include "tools/gn/commands.h"

9 #include "tools/gn/setup.h"	9 #include "tools/gn/setup.h"

10	10

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 FORMAT_TEST(022)	59 FORMAT_TEST(022)

60 FORMAT_TEST(023)	60 FORMAT_TEST(023)

61 FORMAT_TEST(024)	61 FORMAT_TEST(024)

62 FORMAT_TEST(025)	62 FORMAT_TEST(025)

63 FORMAT_TEST(026)	63 FORMAT_TEST(026)

64 FORMAT_TEST(027)	64 FORMAT_TEST(027)

65 FORMAT_TEST(028)	65 FORMAT_TEST(028)

66 FORMAT_TEST(029)	66 FORMAT_TEST(029)

67 FORMAT_TEST(030)	67 FORMAT_TEST(030)

68 FORMAT_TEST(031)	68 FORMAT_TEST(031)

69 // TODO(scottmg): Continued conditions aren't aligned properly: FORMAT_TEST(032)	69 FORMAT_TEST(032)

70 FORMAT_TEST(033)	70 FORMAT_TEST(033)

71 // TODO(scottmg): args+rebase_path unnecessarily split: FORMAT_TEST(034)	71 // TODO(scottmg): args+rebase_path unnecessarily split: FORMAT_TEST(034)

72 FORMAT_TEST(035)	72 FORMAT_TEST(035)

73 FORMAT_TEST(036)	73 FORMAT_TEST(036)

74 // TODO(scottmg): Ugly line breaking: FORMAT_TEST(037)	74 FORMAT_TEST(037)

75 FORMAT_TEST(038)	75 FORMAT_TEST(038)

76 // TODO(scottmg): Bad break, exceeding 80 col: FORMAT_TEST(039)	76 FORMAT_TEST(039)

77 // TODO(scottmg): Bad break, exceeding 80 col: FORMAT_TEST(040)	77 // TODO(scottmg): Bad break, exceeding 80 col: FORMAT_TEST(040)

78 FORMAT_TEST(041)	78 FORMAT_TEST(041)

	79 FORMAT_TEST(042)

	80 // TODO(scottmg): Unnecessary line break: FORMAT_TEST(043)

	81 // TODO(scottmg): Dewrapped caused exceeding 80 col: FORMAT_TEST(044)

	82 FORMAT_TEST(045)

	83 FORMAT_TEST(046)

	84 FORMAT_TEST(047)

	85 // TODO(scottmg): Unnecessary blank line inserted: FORMAT_TEST(048)

	86 // TODO(scottmg): Eval is broken (!) and comment output might have extra ,

	87 // FORMAT_TEST(049)

	88 FORMAT_TEST(050)

	89 FORMAT_TEST(051)

	90 // TODO(scottmg): Ugly separation: FORMAT_TEST(052)

OLD	NEW

« no previous file with comments | « tools/gn/command_format.cc ('k') | tools/gn/format_test_data/003.golden » ('j') | no next file with comments »