Issue 748853002: Add support for hoisting layers in pictures drawn with a matrix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 748853002: Add support for hoisting layers in pictures drawn with a matrix (Closed)

Created:
6 years, 1 month ago by robertphillips

Modified:
6 years ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Add support for hoisting layers in pictures drawn with a matrix Although Chromium doesn't use the drawPicture matrix parameter for their tiling, our local code does. Without such drawPicture calls break layer hoisting. BUG=skia:2315 Committed: https://skia.googlesource.com/skia/+/30d7841f906116c3945ec8125a816a5c5462fed0

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -33 lines)			Patch
M	src/core/SkMultiPictureDraw.cpp	View	1	5 chunks	+12 lines, -6 lines	0 comments	Download
M	src/gpu/GrLayerHoister.h	View	1 2	4 chunks	+4 lines, -0 lines	0 comments	Download
M	src/gpu/GrLayerHoister.cpp	View	1 2	6 chunks	+17 lines, -10 lines	0 comments	Download
M	src/gpu/GrRecordReplaceDraw.h	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/gpu/GrRecordReplaceDraw.cpp	View	1 2	5 chunks	+6 lines, -7 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1	5 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748853002/40001

6 years ago (2014-11-24 17:37:23 UTC) #5

commit-bot: I haz the power

6 years ago (2014-11-24 17:49:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/30d7841f906116c3945ec8125a816a5c5462fed0