Issue 748803005: SkPicture::SnapshotArray doesn't really stand to benefit from refcounting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 748803005: SkPicture::SnapshotArray doesn't really stand to benefit from refcounting. (Closed)

Created:
6 years, 1 month ago by mtklein_C

Modified:
6 years, 1 month ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

SkPicture::SnapshotArray doesn't really stand to benefit from refcounting. BUG=skia: Committed: https://skia.googlesource.com/skia/+/19ac76753ec9f71a8eb0b58cf0450fd4e59f2a7c

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	include/core/SkPicture.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPictureRecorder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748803005/1

6 years, 1 month ago (2014-11-21 20:10:40 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-21 20:20:38 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19ac76753ec9f71a8eb0b58cf0450fd4e59f2a7c