src/core/SkPicture.cpp - Issue 748803005: SkPicture::SnapshotArray doesn't really stand to benefit from refcounting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicture.cpp

Issue 748803005: SkPicture::SnapshotArray doesn't really stand to benefit from refcounting. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkPicture.cpp

diff --git a/src/core/SkPicture.cpp b/src/core/SkPicture.cpp

index a8e160f855f7a8aa7693d9de563c49c9a7360992..b24f7196d0d25f13b55149c94fb6bf764f70e353 100644

--- a/src/core/SkPicture.cpp

+++ b/src/core/SkPicture.cpp

@@ -523,7 +523,7 @@ SkPicture::SkPicture(const SkRect& cullRect, SkRecord* record, SnapshotArray* dr

, fCullRect(cullRect)

, fRecord(record)

, fBBH(SkSafeRef(bbh))

- , fDrawablePicts(SkSafeRef(drawablePicts))

+ , fDrawablePicts(drawablePicts)

, fAnalysis(*fRecord)

{}

« no previous file with comments | « include/core/SkPicture.h ('k') | src/core/SkPictureRecorder.cpp » ('j') | no next file with comments »