|
|
DescriptionEnable the OOP PDF viewer as the default
BUG=303491
Committed: https://crrev.com/ff54748f98853a5fedb2010c0c0f6748ded9cf2e
Cr-Commit-Position: refs/heads/master@{#311010}
Patch Set 1 #
Messages
Total messages: 16 (4 generated)
raymes@chromium.org changed reviewers: + sammc@chromium.org, thestig@chromium.org
Hey Lei: We're planning to land this right after branch point (Monday). PTAL :)
Is this just to get it out on dev channel for a few releases for testing, or is this a more permanent flag flip?
This is intended to be permanent unless there are major regressions or crashes which can't be quickly addressed, in which case we will revert until they're fixed. On Wed Jan 07 2015 at 7:27:50 AM <thestig@chromium.org> wrote: > Is this just to get it out on dev channel for a few releases for testing, > or is > this a more permanent flag flip? > > https://codereview.chromium.org/748553003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
What about the open bugs that bug 303491 is blocked on? On 2015/01/06 22:41:07, raymes wrote: > This is intended to be permanent unless there are major regressions or > crashes which can't be quickly addressed, in which case we will revert > until they're fixed.
Most of them have fixes in progress and shouldn't stop normal use. They will definitely be fixed before branch point. If it turns out they cause significant problems then we can revert. On Wed Jan 07 2015 at 9:42:40 AM <thestig@chromium.org> wrote: > What about the open bugs that bug 303491 is blocked on? > > On 2015/01/06 22:41:07, raymes wrote: > > This is intended to be permanent unless there are major regressions or > > crashes which can't be quickly addressed, in which case we will revert > > until they're fixed. > > https://codereview.chromium.org/748553003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm I'll mark the bugs M42...
Thank you! On Wed Jan 07 2015 at 9:45:48 AM <thestig@chromium.org> wrote: > lgtm > > I'll mark the bugs M42... > > https://codereview.chromium.org/748553003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by raymes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748553003/1
The CQ bit was unchecked by raymes@chromium.org
The CQ bit was checked by raymes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748553003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ff54748f98853a5fedb2010c0c0f6748ded9cf2e Cr-Commit-Position: refs/heads/master@{#311010}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/835273005/ by raymes@chromium.org. The reason for reverting is: This got merged badly and flipped the wrong flag.. |