Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 748553003: Enable the OOP PDF viewer as the default (Closed)

Created:
6 years ago by raymes
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable the OOP PDF viewer as the default BUG=303491 Committed: https://crrev.com/ff54748f98853a5fedb2010c0c0f6748ded9cf2e Cr-Commit-Position: refs/heads/master@{#311010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
raymes
Hey Lei: We're planning to land this right after branch point (Monday). PTAL :)
5 years, 11 months ago (2015-01-06 06:32:40 UTC) #2
Lei Zhang
Is this just to get it out on dev channel for a few releases for ...
5 years, 11 months ago (2015-01-06 20:27:47 UTC) #3
raymes
This is intended to be permanent unless there are major regressions or crashes which can't ...
5 years, 11 months ago (2015-01-06 22:41:07 UTC) #4
Lei Zhang
What about the open bugs that bug 303491 is blocked on? On 2015/01/06 22:41:07, raymes ...
5 years, 11 months ago (2015-01-06 22:42:39 UTC) #5
raymes
Most of them have fixes in progress and shouldn't stop normal use. They will definitely ...
5 years, 11 months ago (2015-01-06 22:45:13 UTC) #6
Lei Zhang
lgtm I'll mark the bugs M42...
5 years, 11 months ago (2015-01-06 22:45:47 UTC) #7
raymes
Thank you! On Wed Jan 07 2015 at 9:45:48 AM <thestig@chromium.org> wrote: > lgtm > ...
5 years, 11 months ago (2015-01-06 22:48:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748553003/1
5 years, 11 months ago (2015-01-11 22:21:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748553003/1
5 years, 11 months ago (2015-01-11 22:31:04 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-11 23:53:21 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ff54748f98853a5fedb2010c0c0f6748ded9cf2e Cr-Commit-Position: refs/heads/master@{#311010}
5 years, 11 months ago (2015-01-11 23:54:17 UTC) #15
raymes
5 years, 11 months ago (2015-01-13 04:39:27 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/835273005/ by raymes@chromium.org.

The reason for reverting is: This got merged badly and flipped the wrong flag..

Powered by Google App Engine
This is Rietveld 408576698