Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 748513003: [DevTools] Removed newline from remote device model name. (Closed)

Created:
6 years, 1 month ago by vkuzkokov
Modified:
6 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed newline from remote device model name. BUG= Committed: https://crrev.com/d93c2714b76188ad0da9ac65d223c41b727d5012 Cr-Commit-Position: refs/heads/master@{#305240}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/devtools/device/adb/adb_device_info_query.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
vkuzkokov
6 years, 1 month ago (2014-11-21 14:07:42 UTC) #2
vkuzkokov
Used TrimWshitespaceASCII
6 years, 1 month ago (2014-11-21 17:11:44 UTC) #3
dgozman
lgtm
6 years, 1 month ago (2014-11-21 17:15:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748513003/20001
6 years, 1 month ago (2014-11-21 17:17:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-21 18:04:07 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 18:05:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d93c2714b76188ad0da9ac65d223c41b727d5012
Cr-Commit-Position: refs/heads/master@{#305240}

Powered by Google App Engine
This is Rietveld 408576698