chrome/browser/devtools/device/adb/adb_device_info_query.cc - Issue 748513003: [DevTools] Removed newline from remote device model name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/adb/adb_device_info_query.cc

Issue 748513003: [DevTools] Removed newline from remote device model name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/adb/adb_device_info_query.cc

diff --git a/chrome/browser/devtools/device/adb/adb_device_info_query.cc b/chrome/browser/devtools/device/adb/adb_device_info_query.cc

index 2b44acd78ddcf8201e001891bba891ff40e813b0..14b2de6bc78015a08dae9dbcedeaeda57fce4442 100644

--- a/chrome/browser/devtools/device/adb/adb_device_info_query.cc

+++ b/chrome/browser/devtools/device/adb/adb_device_info_query.cc

@@ -208,7 +208,7 @@ void AdbDeviceInfoQuery::ReceivedModel(int result,

Respond();

return;

}

- device_info_.model = response;

+ TrimWhitespaceASCII(response, base::TRIM_ALL, &device_info_.model);

device_info_.connected = true;

command_callback_.Run(

kDumpsysCommand,

« no previous file with comments | « no previous file | no next file » | no next file with comments »