Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 748433002: [Android] Isolate OverscrollRefresh from device density (Closed)

Created:
6 years, 1 month ago by jdduke (slow)
Modified:
6 years, 1 month ago
Reviewers:
whywhat
CC:
chromium-reviews, darin-cc_chromium.org, jam, aelias_OOO_until_Jul13
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Isolate OverscrollRefresh from device density Make the OverscrollRefresh effect take the target drag threshold as a parameter. This isolates it from direct dependencies on the device scale factor, making associated unit tests determnistics across all devices. BUG=435125 Committed: https://crrev.com/d28baa33b8dcc3c0c8f9f23e008200bc0464d0af Cr-Commit-Position: refs/heads/master@{#305026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M content/browser/android/overscroll_controller_android.cc View 2 chunks +7 lines, -1 line 0 comments Download
M content/browser/android/overscroll_refresh.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/android/overscroll_refresh.cc View 4 chunks +5 lines, -12 lines 0 comments Download
M content/browser/android/overscroll_refresh_unittest.cc View 9 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
whywhat
lgtm
6 years, 1 month ago (2014-11-20 16:29:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748433002/1
6 years, 1 month ago (2014-11-20 16:38:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 17:27:34 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:28:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d28baa33b8dcc3c0c8f9f23e008200bc0464d0af
Cr-Commit-Position: refs/heads/master@{#305026}

Powered by Google App Engine
This is Rietveld 408576698