[Android] Isolate OverscrollRefresh from device density

content/browser/android/overscroll_refresh_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer.h"
 #include "content/browser/android/overscroll_refresh.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/android/system_ui_resource_manager.h"
 
 namespace content {
 
+const float kDragTargetPixels = 100;
+
 gfx::SizeF DefaultViewportSize() {
   return gfx::SizeF(512, 512);
 }
 
 class OverscrollRefreshTest : public OverscrollRefreshClient,
                               public ui::SystemUIResourceManager,
                               public testing::Test {
  public:
   OverscrollRefreshTest() : refresh_triggered_(false) {}
 
@@ skipping 20 matching lines @@
   cc::UIResourceId GetUIResourceId(ui::SystemUIResourceType) override {
     return 0;
   }
 
  private:
   bool refresh_triggered_;
   bool still_refreshing_;
 };
 
 TEST_F(OverscrollRefreshTest, Basic) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
 
   gfx::Vector2dF origin_scroll_offset;
   effect.UpdateDisplay(DefaultViewportSize(), origin_scroll_offset);
   EXPECT_FALSE(effect.IsActive());
   EXPECT_FALSE(effect.IsAwaitingScrollUpdateAck());
 
   effect.OnScrollBegin();
   EXPECT_FALSE(effect.IsActive());
   EXPECT_TRUE(effect.IsAwaitingScrollUpdateAck());
 
@@ skipping 42 matching lines @@
 
   // The effect should terminate in a timely fashion.
   EXPECT_GT(current_time.ToInternalValue(), initial_time.ToInternalValue());
   EXPECT_LE(
       current_time.ToInternalValue(),
       (initial_time + base::TimeDelta::FromSeconds(10)).ToInternalValue());
   EXPECT_FALSE(effect.IsActive());
 }
 
 TEST_F(OverscrollRefreshTest, AnimationTerminatesEvenIfRefreshNeverTerminates) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
   effect.UpdateDisplay(DefaultViewportSize(), gfx::Vector2dF());
   effect.OnScrollBegin();
   ASSERT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
   ASSERT_TRUE(effect.IsAwaitingScrollUpdateAck());
   effect.OnScrollUpdateAck(false);
   ASSERT_TRUE(effect.IsActive());
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
@@ skipping 11 matching lines @@
     current_time += base::TimeDelta::FromMilliseconds(16);
 
   EXPECT_GT(current_time.ToInternalValue(), initial_time.ToInternalValue());
   EXPECT_LE(
       current_time.ToInternalValue(),
       (initial_time + base::TimeDelta::FromSeconds(10)).ToInternalValue());
   EXPECT_FALSE(effect.IsActive());
 }
 
 TEST_F(OverscrollRefreshTest, NotTriggeredIfBelowThreshold) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
   effect.UpdateDisplay(DefaultViewportSize(), gfx::Vector2dF());
   effect.OnScrollBegin();
   ASSERT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
   ASSERT_TRUE(effect.IsAwaitingScrollUpdateAck());
   effect.OnScrollUpdateAck(false);
   ASSERT_TRUE(effect.IsActive());
 
   // Terminating the pull before it exceeds the threshold will prevent refresh.
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
   effect.OnScrollEnd(gfx::Vector2dF());
   EXPECT_FALSE(GetAndResetRefreshTriggered());
 }
 
 TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialYOffsetIsNotZero) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
 
   // A positive y scroll offset at the start of scroll will prevent activation,
   // even if the subsequent scroll overscrolls upward.
   gfx::Vector2dF nonzero_offset(0, 10);
   effect.UpdateDisplay(DefaultViewportSize(), nonzero_offset);
   effect.OnScrollBegin();
 
   effect.UpdateDisplay(DefaultViewportSize(), gfx::Vector2dF());
   ASSERT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
   EXPECT_FALSE(effect.IsActive());
   EXPECT_FALSE(effect.IsAwaitingScrollUpdateAck());
   effect.OnScrollUpdateAck(false);
   EXPECT_FALSE(effect.IsActive());
   EXPECT_FALSE(effect.IsAwaitingScrollUpdateAck());
   EXPECT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
   effect.OnScrollEnd(gfx::Vector2dF());
   EXPECT_FALSE(GetAndResetRefreshTriggered());
 }
 
 TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialScrollDownward) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
   effect.UpdateDisplay(DefaultViewportSize(), gfx::Vector2dF());
   effect.OnScrollBegin();
 
   // A downward initial scroll will prevent activation, even if the subsequent
   // scroll overscrolls upward.
   ASSERT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, -10)));
   EXPECT_FALSE(effect.IsActive());
   EXPECT_FALSE(effect.IsAwaitingScrollUpdateAck());
 
   effect.OnScrollUpdateAck(false);
   EXPECT_FALSE(effect.IsActive());
   EXPECT_FALSE(effect.IsAwaitingScrollUpdateAck());
   EXPECT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
   effect.OnScrollEnd(gfx::Vector2dF());
   EXPECT_FALSE(GetAndResetRefreshTriggered());
 }
 
 TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialScrollOrTouchConsumed) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
   effect.UpdateDisplay(DefaultViewportSize(), gfx::Vector2dF());
   effect.OnScrollBegin();
   ASSERT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
   ASSERT_TRUE(effect.IsAwaitingScrollUpdateAck());
 
   // Consumption of the initial touchmove or scroll should prevent future
   // activation.
   effect.OnScrollUpdateAck(true);
   EXPECT_FALSE(effect.IsActive());
   EXPECT_FALSE(effect.IsAwaitingScrollUpdateAck());
   EXPECT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
   effect.OnScrollUpdateAck(false);
   EXPECT_FALSE(effect.IsActive());
   EXPECT_FALSE(effect.IsAwaitingScrollUpdateAck());
   EXPECT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
   effect.OnScrollEnd(gfx::Vector2dF());
   EXPECT_FALSE(GetAndResetRefreshTriggered());
 }
 
 TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialScrollsJanked) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
   effect.UpdateDisplay(DefaultViewportSize(), gfx::Vector2dF());
   effect.OnScrollBegin();
   ASSERT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
   ASSERT_TRUE(effect.IsAwaitingScrollUpdateAck());
   effect.OnScrollUpdateAck(false);
   ASSERT_TRUE(effect.IsActive());
 
   // It should take more than just one or two large scrolls to trigger,
   // mitigating likelihood of jank triggering the effect.
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
   effect.OnScrollEnd(gfx::Vector2dF());
   EXPECT_FALSE(GetAndResetRefreshTriggered());
 }
 
 TEST_F(OverscrollRefreshTest, NotTriggeredIfFlungDownward) {
-  OverscrollRefresh effect(this, this);
+  OverscrollRefresh effect(this, this, kDragTargetPixels);
   effect.UpdateDisplay(DefaultViewportSize(), gfx::Vector2dF());
   effect.OnScrollBegin();
   ASSERT_FALSE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
   ASSERT_TRUE(effect.IsAwaitingScrollUpdateAck());
   effect.OnScrollUpdateAck(false);
   ASSERT_TRUE(effect.IsActive());
 
   // Ensure the pull exceeds the necessary threshold.
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
   EXPECT_TRUE(effect.WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
 
   // Terminating the pull with a down-directed fling should prevent triggering.
   effect.OnScrollEnd(gfx::Vector2dF(0, -1000));
   EXPECT_FALSE(GetAndResetRefreshTriggered());
 }
 
 }  // namespace content