Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 748153002: Use remove_build_metadata.py on all the trybots (take 3). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium_trybot.py
diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py
index b5db1169577abeea13e2ff46c954b5c88fb27c19..77fd0973553175096f6d6bcd42b9b144dda395c5 100644
--- a/scripts/slave/recipes/chromium_trybot.py
+++ b/scripts/slave/recipes/chromium_trybot.py
@@ -929,7 +929,10 @@ def GenSteps(api):
raise
if bot_config.get('use_isolate') or has_swarming_tests:
- # TODO(sebmarchand): remove_build_metadata, http://crbug.com/314403 .
+ # Remove the build metadata from the binaries. Currently it's a noop on
M-A Ruel 2014/11/21 19:25:09 The command is not exactly right due to android, I
Sébastien Marchand 2014/11/21 19:34:24 Done.
+ # all platforms except Windows where it run zap_timestamp.exe on all the
+ # PE images.
+ api.isolate.remove_build_metadata()
# Isolate all prepared targets, will look for *.isolated.gen.json files.
api.isolate.isolate_tests(api.chromium.output_dir, verbose=True)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698