Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 748073004: Disable implicit conversion of scoped_refptr<T> to T* on Windows. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable implicit conversion of scoped_refptr<T> to T* on Windows. Finally!!! BUG=110610 Committed: https://crrev.com/1c3841d1c87f5332ba6550ed3b4f113c026b0ce3 Cr-Commit-Position: refs/heads/master@{#305558}

Patch Set 1 #

Patch Set 2 : comptr too #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M base/memory/ref_counted.h View 1 chunk +1 line, -1 line 2 comments Download
M base/win/scoped_comptr.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
Note: I'm not sure if this is actually landable yet (I'm still finishing a local ...
6 years, 1 month ago (2014-11-22 01:14:45 UTC) #2
Nico
lgtm if the remaining 67% are happy too https://codereview.chromium.org/748073004/diff/20001/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/748073004/diff/20001/base/memory/ref_counted.h#newcode20 base/memory/ref_counted.h:20: #if ...
6 years, 1 month ago (2014-11-22 01:19:25 UTC) #3
dcheng
https://codereview.chromium.org/748073004/diff/20001/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/748073004/diff/20001/base/memory/ref_counted.h#newcode20 base/memory/ref_counted.h:20: #if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_IOS) || defined(OS_ANDROID) || ...
6 years, 1 month ago (2014-11-22 01:20:22 UTC) #4
dcheng
I've landed all blockers to this patch that I found over the weekend... hopefully nothing ...
6 years ago (2014-11-24 23:07:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748073004/20001
6 years ago (2014-11-24 23:08:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-25 01:49:36 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-25 01:50:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c3841d1c87f5332ba6550ed3b4f113c026b0ce3
Cr-Commit-Position: refs/heads/master@{#305558}

Powered by Google App Engine
This is Rietveld 408576698