base/memory/ref_counted.h - Issue 748073004: Disable implicit conversion of scoped_refptr<T> to T* on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/ref_counted.h

Issue 748073004: Disable implicit conversion of scoped_refptr<T> to T* on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comptr too Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/ref_counted.h

diff --git a/base/memory/ref_counted.h b/base/memory/ref_counted.h

index 7869e72d11126cdc1492840b14c68b3a393de54a..e05f45dc8a2d5dc3a765f466a8ab6eefd8694357 100644

--- a/base/memory/ref_counted.h

+++ b/base/memory/ref_counted.h

@@ -17,7 +17,7 @@

#include "base/threading/thread_collision_warner.h"

#include "build/build_config.h"

-#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_IOS) || defined(OS_ANDROID)

+#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_IOS) || defined(OS_ANDROID) || defined(OS_WIN)

Nico 2014/11/22 01:19:24 Is anything missing from this list? Might want to

dcheng 2014/11/22 01:20:22 I wanted to do that in a followup--just in case th

#define DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR

#endif

« no previous file with comments | « no previous file | base/win/scoped_comptr.h » ('j') | no next file with comments »