When doing selection from Actionmode item then IME get closed. and focus get lost. IME should not c…

Preserve IME state when clearing the selection

When a paste or cut operation is performed in an editable region, and
the action bar is dismissed, the IME state should be preserved. Ensure
this by always using the editable region bit when clearing the selection
upon action bar dismissal.

BUG=435810
Committed: https://crrev.com/d1d74981ce7baa010996c82a7b3423d06af466f1
Cr-Commit-Position: refs/heads/master@{#305594}

[Deepak, 2014-11-22 08:44:43]

deepak.m1@samsung.com changed reviewers:
+ tedchoc@chromium.org

[Deepak, 2014-11-22 08:44:44]

PTAL.

[Ted C, 2014-11-24 19:52:07]

tedchoc@chromium.org changed reviewers:
+ jdduke@chromium.org

[Ted C, 2014-11-24 19:52:07]

@jdduke, can you take a look at this?  The described behavior sounds reasonable
and consistent with android text views, but I'm not sure how best to hook into
the input flow so you're a better reviewer here.

[jdduke (slow), 2014-11-24 21:12:00]

jdduke@chromium.org changed reviewers:
+ benm@chromium.org, sgurun@chromium.org

[jdduke (slow), 2014-11-24 21:12:00]

Adding benm@ and sgurun@, as the preceding change was picked to M39 for WebView.

[jdduke (slow), 2014-11-24 21:14:20]

https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1330:
if (isSelectionEditable()) {
Actually, can we just change this to be |if (mFocusedNodeEditable) }|? Does that
solve the problem?

[sgurun-gerrit only, 2014-11-24 21:58:06]

sgurun@chromium.org changed reviewers:
+ hush@chromium.org

[hush (inactive), 2014-11-24 23:23:56]

https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1330:
if (isSelectionEditable()) {
On 2014/11/24 21:14:20, jdduke wrote:
> Actually, can we just change this to be |if (mFocusedNodeEditable) }|? Does
that
> solve the problem?

I tried it and it worked.

[jdduke (slow), 2014-11-24 23:28:11]

https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1330:
if (isSelectionEditable()) {
On 2014/11/24 23:23:56, hush wrote:
> On 2014/11/24 21:14:20, jdduke wrote:
> > Actually, can we just change this to be |if (mFocusedNodeEditable) }|? Does
> that
> > solve the problem?
> 
> I tried it and it worked. 

Thanks, let's go with that instead if we can.

[Deepak, 2014-11-25 04:28:09]

On 2014/11/24 23:28:11, jdduke wrote:
>
https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
> (right):
> 
>
https://codereview.chromium.org/747773003/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1330:
> if (isSelectionEditable()) {
> On 2014/11/24 23:23:56, hush wrote:
> > On 2014/11/24 21:14:20, jdduke wrote:
> > > Actually, can we just change this to be |if (mFocusedNodeEditable) }|?
Does
> > that
> > > solve the problem?
> > 
> > I tried it and it worked. 
> 
> Thanks, let's go with that instead if we can.

Thanks for review.
Changes done & checked, it is working well.
PTAL

[jdduke (slow), 2014-11-25 05:15:34]

Thanks, lgtm.

[jdduke (slow), 2014-11-25 05:15:56]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-11-25 05:16:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/747773003/40001

[commit-bot: I haz the power, 2014-11-25 06:11:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-25 06:12:31]

Patchset 3 (id:??) landed as
https://crrev.com/d1d74981ce7baa010996c82a7b3423d06af466f1
Cr-Commit-Position: refs/heads/master@{#305594}