content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 747773003: When doing selection from Actionmode item then IME get closed. and focus get lost. IME should not c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 747773003: When doing selection from Actionmode item then IME get closed. and focus get lost. IME should not c… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 8ab66704bd9049ef44bf9c4e1a57f4c3699237e4..d447ca8855b8b617da109996ed4ecbe972dfa104 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1327,7 +1327,7 @@ public class ContentViewCore

}

private void clearUserSelection() {

- if (isSelectionEditable()) {

+ if (mFocusedNodeEditable) {

if (mInputConnection != null) {

int selectionEnd = Selection.getSelectionEnd(mEditable);

mInputConnection.setSelection(selectionEnd, selectionEnd);

« no previous file with comments | « no previous file | no next file » | no next file with comments »