Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 747663002: Audit all of sky's system <> style includes (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Audit all of sky's system <> style includes I wrote a little script to do this. I'll attach it to the bug in case Blink wants it. R=abarth@chromium.org BUG=435361 Committed: https://chromium.googlesource.com/external/mojo/+/2157ad95c6ebcd09ea7ee37446bce027ca72c22d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -66 lines) Patch
M sky/engine/bindings/core/v8/ScriptRegexp.h View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/core/editing/TextAffinity.h View 2 chunks +1 line, -19 lines 0 comments Download
M sky/engine/core/inspector/AsyncCallStackTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/inspector/InjectedScriptManager.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/engine/core/inspector/PromiseTracker.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/engine/platform/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/weborigin/KURL.h View 1 chunk +7 lines, -7 lines 0 comments Download
M sky/engine/platform/weborigin/KURL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/engine/public/platform/WebFloatPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/WebFloatPoint3D.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/WebFloatRect.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/WebFloatSize.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/public/platform/WebPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/WebRect.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/WebSize.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/public/platform/WebString.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/public/platform/WebURL.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/public/web/linux/WebFontRendering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/web/WebFontImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/text/WTFString.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-11-20 23:52:17 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-20 23:53:26 UTC) #2
eseidel
6 years, 1 month ago (2014-11-20 23:55:01 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2157ad95c6ebcd09ea7ee37446bce027ca72c22d.

Powered by Google App Engine
This is Rietveld 408576698