Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 747283005: [turbofan]: Port lea changes to ia32 (Closed)

Created:
6 years ago by danno
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan]: Port lea changes to ia32

Patch Set 1 #

Patch Set 2 : All tests pass #

Patch Set 3 : Latest #

Total comments: 3

Patch Set 4 : Review feedback #

Patch Set 5 : Review feedback #

Patch Set 6 : Tweak for x64 #

Patch Set 7 : For Dan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -455 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +34 lines, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 8 chunks +158 lines, -353 lines 0 comments Download
M src/compiler/node-matchers.h View 1 2 3 4 7 chunks +57 lines, -30 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 4 5 5 chunks +33 lines, -30 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 14 chunks +73 lines, -40 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
danno
PTAL
6 years ago (2014-12-11 10:12:10 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/747283005/diff/40001/src/compiler/machine-operator.cc File src/compiler/machine-operator.cc (right): https://codereview.chromium.org/747283005/diff/40001/src/compiler/machine-operator.cc#newcode178 src/compiler/machine-operator.cc:178: Operator::kCommutative, \ Err, what's that? https://codereview.chromium.org/747283005/diff/40001/src/compiler/machine-operator.cc#newcode198 src/compiler/machine-operator.cc:198: Operator::kNoRead | ...
6 years ago (2014-12-11 10:16:21 UTC) #3
danno
PT another look
6 years ago (2014-12-11 11:14:07 UTC) #4
Benedikt Meurer
LGTM
6 years ago (2014-12-11 11:15:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747283005/80001
6 years ago (2014-12-11 11:16:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747283005/100001
6 years ago (2014-12-11 11:19:11 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-11 11:52:53 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:100001)

Powered by Google App Engine
This is Rietveld 408576698