chrome/browser/themes/theme_service.cc - Issue 747013003: Various optimizations to reduce the number of temporary allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_service.cc

Issue 747013003: Various optimizations to reduce the number of temporary allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Responded to comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/themes/theme_service.cc

diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc

index 053cfb89c26a91125ec60624a12776b5f9e38d57..67ecaf849b0bb06158761b504070160b0c748cf3 100644

--- a/chrome/browser/themes/theme_service.cc

+++ b/chrome/browser/themes/theme_service.cc

@@ -236,7 +236,7 @@ bool ThemeService::ShouldUseNativeFrame() const {

}

bool ThemeService::HasCustomImage(int id) const {

- if (!Properties::IsThemeableImage(id))

+ if (!BrowserThemePack::IsPersistentImageID(id))

Peter Kasting 2014/12/03 22:08:38 Optional: While you're here, a shorter way would b

return false;

if (theme_supplier_.get())

« no previous file with comments | « chrome/browser/themes/theme_properties.cc ('k') | chrome/browser/ui/prefs/prefs_tab_helper.cc » ('j') | no next file with comments »